Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Witness: Fix potential caching issue #3307

Closed
wants to merge 2 commits into from
Closed

The Witness: Fix potential caching issue #3307

wants to merge 2 commits into from

Conversation

NewSoupVi
Copy link
Member

Today I learned that lru_cache does not take self into account for an instance method.

This might lead to weird slot bleed issues with Witness seeds.
Don't have any reports, but should still be fixed

@NewSoupVi NewSoupVi added the is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. label May 16, 2024
@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label May 16, 2024
@NewSoupVi
Copy link
Member Author

NewSoupVi commented May 17, 2024 •
edited
Loading

Utils.cache_self1 has been considered, but #2698 changes this function to have an extra arg, so it'd just be changed back again anyway.

@Berserker66
Copy link
Member

I have no idea if your approach works, but we have cache_self1 in Utils for this.

@NewSoupVi
Copy link
Member Author

Decided to use cache_self1 after all and just deal with the consequences on the other PR somehow

@NewSoupVi NewSoupVi added the affects: release/blocker Issues/PRs that must be addressed before next official release. label May 17, 2024
@NewSoupVi
Copy link
Member Author

I have a better solution to the issue in #2698.

@NewSoupVi NewSoupVi closed this May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
affects: release/blocker Issues/PRs that must be addressed before next official release. is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NewSoupVi @Berserker66